A couple of dask-expr fixes for new parquet cache #10880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
changed the title
fjetter
changed the title
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 10m 12s ⏱️ - 1m 50s For more details on these failures, see this check. Results for commit 6758d14. ± Comparison against base commit 0eab32e. ♻️ This comment has been updated with latest results. |
fjetter
commented
Feb 2, 2024
Comment on lines
+191
to
+192
| def __dask_tokenize__(self): | ||
| return tokenize(self.name, self.keys) |
There was a problem hiding this comment.
this should include the type as well
phofl
approved these changes
Feb 2, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for dask/dask-expr#798
I haven't really tried to understand why the one test now no longer deviates. I guess the previous deviation was a caching bug and the cache in dask/dask-expr#798 is a little more specific.
Note: This one test will now fail on the dask-expr test branch until dask/dask-expr#798 is merged as well