New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment documentation #10882
Conversation
This adds code samples to the recommended sections and a bit of context around the challenges of each approach.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 13m 25s ⏱️ -7s For more details on these failures, see this check. Results for commit d4cabd8. ± Comparison against base commit 08341db. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrocklin. Overall this looks like a nice improvement to me. All the comments / suggestions I left are non-blocking
docs/source/deploying.rst
Outdated
|
||
- `Dask Cloud Provider <https://cloudprovider.dask.org/en/latest/>`_: a pure and simple OSS solution that sets up Dask workers on cloud VMs, supporting AWS, GCP, Azure, and also other commercial clouds like Hetzner and Digital Ocean. | ||
|
||
- `Dask-Yarn <https://yarn.dask.org>`_: deploys Dask on legacy YARN clusters, such as can be set up with AWS EMR or Google Cloud Dataproc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Non-blocking comment] You have a much better sense for if the term "legacy" applies here. I definitely see less Dask traffic around YARN clusters these days -- just noting that this is the first time I'm seeing the term "legacy" in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm comfortable throwing some shade at Yarn today.
docs/source/deploying.rst
Outdated
.. _Coiled: https://coiled.io?utm_source=dask-docs&utm_medium=deploying | ||
.. |Coiled| replace:: **Coiled** | ||
.. |Coiled| replace:: **Coiled** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and the similar lines in other sections) aren't needed anymore if we're not going to bold the recommended deployment project.
Thoughts on continuing to bold them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to bold them, I just didn't want to deal with the sphinx stuff to make that happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem -- just pushed a commit that makes them bold
This adds code samples to the recommended sections and a bit of context around the challenges of each approach.
cc @jrbourbeau