Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment documentation #10882

Merged
merged 4 commits into from Feb 1, 2024
Merged

Conversation

mrocklin
Copy link
Member

@mrocklin mrocklin commented Feb 1, 2024

This adds code samples to the recommended sections and a bit of context around the challenges of each approach.

cc @jrbourbeau

This adds code samples to the recommended sections and a bit of context
around the challenges of each approach.
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 13m 25s ⏱️ -7s
 12 984 tests ±0   12 054 ✅  - 1     929 💤 ±0  1 ❌ +1 
160 189 runs  ±0  143 612 ✅ ±0  16 574 💤  - 3  3 ❌ +3 

For more details on these failures, see this check.

Results for commit d4cabd8. ± Comparison against base commit 08341db.

♻️ This comment has been updated with latest results.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrocklin. Overall this looks like a nice improvement to me. All the comments / suggestions I left are non-blocking

docs/source/deploying.rst Outdated Show resolved Hide resolved
docs/source/deploying.rst Outdated Show resolved Hide resolved
docs/source/deploying.rst Outdated Show resolved Hide resolved

- `Dask Cloud Provider <https://cloudprovider.dask.org/en/latest/>`_: a pure and simple OSS solution that sets up Dask workers on cloud VMs, supporting AWS, GCP, Azure, and also other commercial clouds like Hetzner and Digital Ocean.

- `Dask-Yarn <https://yarn.dask.org>`_: deploys Dask on legacy YARN clusters, such as can be set up with AWS EMR or Google Cloud Dataproc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Non-blocking comment] You have a much better sense for if the term "legacy" applies here. I definitely see less Dask traffic around YARN clusters these days -- just noting that this is the first time I'm seeing the term "legacy" in this context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm comfortable throwing some shade at Yarn today.

Comment on lines 113 to 114
.. _Coiled: https://coiled.io?utm_source=dask-docs&utm_medium=deploying
.. |Coiled| replace:: **Coiled**
.. |Coiled| replace:: **Coiled**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the similar lines in other sections) aren't needed anymore if we're not going to bold the recommended deployment project.

Thoughts on continuing to bold them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to bold them, I just didn't want to deal with the sphinx stuff to make that happen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem -- just pushed a commit that makes them bold

docs/source/deploying.rst Outdated Show resolved Hide resolved
docs/source/deploying.rst Outdated Show resolved Hide resolved
docs/source/deploying.rst Outdated Show resolved Hide resolved
docs/source/deploying.rst Outdated Show resolved Hide resolved
@jrbourbeau jrbourbeau merged commit bd6aec4 into dask:main Feb 1, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants