Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for dask.dataframe change #10912

Merged
merged 3 commits into from Feb 9, 2024
Merged

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Feb 9, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

First suggestion

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 17m 26s ⏱️ -15s
 12 988 tests ±0   12 058 ✅  - 1     929 💤 ±0  1 ❌ +1 
160 507 runs  ±0  144 026 ✅  - 6  16 479 💤 +4  2 ❌ +2 

For more details on these failures, see this check.

Results for commit a2dba2f. ± Comparison against base commit 34d08c7.

♻️ This comment has been updated with latest results.

dask/dataframe/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
@fjetter fjetter merged commit 3e775b4 into dask:main Feb 9, 2024
25 of 28 checks passed
@phofl phofl deleted the dep_warning branch February 9, 2024 15:35
@rjzamora
Copy link
Member

What is the proposed timeline for (1) changing the "dataframe.query-planning" default, and (2) dropping support for {"dataframe.query-planning": False}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants