Adjust for pandas large string change #10942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 18m 30s ⏱️ + 2m 58s For more details on these failures, see this check. Results for commit b441aaa. ± Comparison against base commit 67ecd26. ♻️ This comment has been updated with latest results. |
jrbourbeau
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thanks @phofl -- this LGTM if CI is happy. Just one non-blocking question
| pdf.to_parquet(tmpdir + "string.parquet") | ||
| df = dd.read_parquet(tmpdir + "string.parquet") | ||
| assert_eq(df, pdf) | ||
| pd.testing.assert_frame_equal(df.compute(), pdf) |
There was a problem hiding this comment.
Does this not happen inside assert_eq above?
There was a problem hiding this comment.
no, but not sure why, I'll open an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesOur testing function did not detect the difference...
Pandas uses large_string instead of string as a backend for the StringDtype