Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse dask/dask groupby Aggregation #10952

Merged
merged 1 commit into from Feb 26, 2024
Merged

Reuse dask/dask groupby Aggregation #10952

merged 1 commit into from Feb 26, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Feb 26, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

This caused some weird import errors when used from outside, so we can reuse the classes

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @phofl

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 23m 9s ⏱️ + 7m 12s
 13 104 tests ±0   12 174 ✅  - 1     929 💤 ±0  1 ❌ +1 
162 287 runs  ±0  145 756 ✅  - 1  16 530 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ff0dc4d. ± Comparison against base commit 0496681.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl!

@hendrikmakait hendrikmakait merged commit 0fac478 into dask:main Feb 26, 2024
28 of 29 checks passed
@phofl phofl deleted the agg branch February 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants