Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix sizeof tests on 32bit #10971

Merged
merged 2 commits into from Mar 1, 2024
Merged

TST: Fix sizeof tests on 32bit #10971

merged 2 commits into from Mar 1, 2024

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Mar 1, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

In that case, the result is 1244, which is ~2.6 * `sys.sizeof` (476),
slightly over the 2 used in the existing test.
The minimum size of the sparse matrix appears to be a bit smaller,
possibly due to Python or NumPy internal changes.
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 18m 15s ⏱️ - 4m 34s
 13 104 tests ±0   12 175 ✅ ±0     929 💤 ±0  0 ❌ ±0 
162 287 runs  ±0  145 762 ✅  - 1  16 525 💤 +1  0 ❌ ±0 

Results for commit a27f267. ± Comparison against base commit d66c5c8.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a 32bit system available but the test adjustments look harmless so I'll go ahead and merge. Thank you!

@fjetter fjetter merged commit 5abd9da into dask:main Mar 1, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants