Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skips for named aggregations #11036

Merged
merged 2 commits into from Apr 3, 2024
Merged

Remove skips for named aggregations #11036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be656c
Remove skips for named aggregations
phofl Apr 3, 2024
ebb9e2a
Remove another skip
phofl Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions dask/dataframe/tests/test_dataframe.py
View file
Open in desktop
Expand Up @@ -4455,9 +4455,6 @@ def test_columns_assignment():
assert_eq(df, ddf)


@pytest.mark.skipif(
DASK_EXPR_ENABLED, reason="Can't make this work with dynamic access"
)
def test_attribute_assignment():
df = pd.DataFrame({"x": [1, 2, 3, 4, 5], "y": [1.0, 2.0, 3.0, 4.0, 5.0]})
ddf = dd.from_pandas(df, npartitions=2)
Expand Down
2 changes: 0 additions & 2 deletions dask/dataframe/tests/test_groupby.py
View file
Open in desktop
Expand Up @@ -3357,7 +3357,6 @@ def test_groupby_numeric_only_None_column_name():
ddf.groupby(lambda x: x).mean(numeric_only=False)


@pytest.mark.skipif(DASK_EXPR_ENABLED, reason="Aggregation not supported")
@pytest.mark.skipif(not PANDAS_GE_140, reason="requires pandas >= 1.4.0")
@pytest.mark.parametrize("shuffle_method", [True, False])
def test_dataframe_named_agg(shuffle_method):
Expand All @@ -3382,7 +3381,6 @@ def test_dataframe_named_agg(shuffle_method):
assert_eq(expected, actual)


@pytest.mark.skipif(DASK_EXPR_ENABLED, reason="Aggregation not supported")
@pytest.mark.skipif(not PANDAS_GE_140, reason="requires pandas >= 1.4.0")
@pytest.mark.parametrize("shuffle_method", [True, False])
@pytest.mark.parametrize("agg", ["count", "mean", partial(np.var, ddof=1)])
Expand Down