Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff/flake8-implicit-str-concat rule ISC001 #11098

Merged
merged 1 commit into from
May 6, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 5, 2024

ISC001 Implicitly concatenated string literals on one line

This rule is currently disabled because it conflicts with the ruff formatter:
astral-sh/ruff#8272

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

	ISC001 Implicitly concatenated string literals on one line

This rule is currently disabled because it conflicts with the formatter:
	astral-sh/ruff#8272
Copy link
Contributor

github-actions bot commented May 5, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 22m 56s ⏱️ + 3m 22s
 13 121 tests ±0   11 730 ✅ ±0     931 💤 ±0  460 ❌ ±0 
162 468 runs  ±0  141 923 ✅ +3  20 085 💤  - 3  460 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4f5aa90. ± Comparison against base commit 067c668.

@phofl phofl merged commit 95121f9 into dask:main May 6, 2024
24 of 26 checks passed
@phofl
Copy link
Collaborator

phofl commented May 6, 2024

thx

@DimitriPapadopoulos DimitriPapadopoulos deleted the ISC001 branch May 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants