Fix map_overlap with new_axis #11128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
dstansby
force-pushed
the
map-blocks-new-axis
branch
from
fd377b8
to
2cb9336
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 26m 34s ⏱️ + 1m 22s For more details on these failures, see this check. Results for commit f3f1e15. ± Comparison against base commit 05a04aa. ♻️ This comment has been updated with latest results. |
dstansby
force-pushed
the
map-blocks-new-axis
branch
from
2cb9336
to
3de2afd
Compare
dstansby
force-pushed
the
map-blocks-new-axis
branch
from
3de2afd
to
1fda35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesFixes #11124.
This does not feel like the nicest or best tested code, so suggestions for improvements to the code or extra tests I could add would be appreciated.