Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to ML page #11129

Merged
merged 1 commit into from
May 17, 2024
Merged

Minor updates to ML page #11129

merged 1 commit into from
May 17, 2024

Conversation

jrbourbeau
Copy link
Member

This PR has some minor changes (mostly all nits) to our recently added ML page

cc @mrocklin

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 21m 38s ⏱️ + 1m 47s
 13 123 tests ±0   12 169 ✅  - 21     931 💤 ±0  11 ❌ + 9  12 🔥 +12 
162 500 runs  +8  142 409 ✅  - 42  20 038 💤  - 1  31 ❌ +29  22 🔥 +22 

For more details on these failures and errors, see this check.

Results for commit 19772ab. ± Comparison against base commit cc1aad6.

Copy link
Member Author

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and merge this PR in so it gets into the release later today (xref dask/community#381). @mrocklin @scharlottej13 my guess is you'll both be okay with the changes here given their minor/nitpicky nature, but if that's not the case I'm happy address any comments you may have in a follow-up PR (sorry for rushing!)

Also, just wanted to note that the test failures here are unrelated to the changes in this PR and have been resolved over in #11131

@jrbourbeau jrbourbeau merged commit 40a095c into dask:main May 17, 2024
17 of 28 checks passed
@jrbourbeau jrbourbeau deleted the ml-nit branch May 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant