Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get docs build passing #11184

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Get docs build passing #11184

merged 4 commits into from
Jun 20, 2024

Conversation

jrbourbeau
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 24m 11s ⏱️ -26s
 13 124 tests ±0   12 145 ✅  - 1     931 💤 ±0  48 ❌ +1 
162 532 runs  ±0  142 451 ✅  - 1  20 033 💤 ±0  48 ❌ +1 

For more details on these failures, see this check.

Results for commit e40623e. ± Comparison against base commit 92bb34e.

♻️ This comment has been updated with latest results.

@jrbourbeau jrbourbeau changed the title Test docs build Get docs build passing Jun 20, 2024
Comment on lines +10 to +11
# Temporarily turning off to get docs build passing
# fail_on_warning: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs build was failing due to this warning (seemingly from Python itself) being elevated to an error

/Users/james/mambaforge/envs/dask-docs-py312/lib/python3.12/functools.py:docstring of functools.CreationDispatch.register_inplace.<locals>.decorator.<locals>.wrapper:10: WARNING: Inline emphasis start-string without end-string.

I haven't been able to track down where this is coming from yet and resolve things properly, so I'm just temporarily removing out "elevate docs warnings to errors" settings to at least get the docs build passing somehow.

Copy link
Member Author

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this in order to get our docs build passing, but will open an issue to track turning fail_on_warning back on

@jrbourbeau jrbourbeau merged commit be42bf4 into dask:main Jun 20, 2024
26 of 27 checks passed
@jrbourbeau jrbourbeau deleted the test-docs-2 branch June 20, 2024 19:11
Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm for now

@jrbourbeau
Copy link
Member Author

Here's the related issue #11193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants