-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get docs build passing #11184
Get docs build passing #11184
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 24m 11s ⏱️ -26s For more details on these failures, see this check. Results for commit e40623e. ± Comparison against base commit 92bb34e. ♻️ This comment has been updated with latest results. |
# Temporarily turning off to get docs build passing | ||
# fail_on_warning: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs build was failing due to this warning (seemingly from Python itself) being elevated to an error
/Users/james/mambaforge/envs/dask-docs-py312/lib/python3.12/functools.py:docstring of functools.CreationDispatch.register_inplace.<locals>.decorator.<locals>.wrapper:10: WARNING: Inline emphasis start-string without end-string.
I haven't been able to track down where this is coming from yet and resolve things properly, so I'm just temporarily removing out "elevate docs warnings to errors" settings to at least get the docs build passing somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this in order to get our docs build passing, but will open an issue to track turning fail_on_warning
back on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm for now
Here's the related issue #11193 |
No description provided.