Python 3.13 fixes #11185
Merged
Python 3.13 fixes #11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.13, `dataclasses.replace()` now raises a `TypeError` rather than a `ValueError` when a field is declared with init=False (or when an init variable is not specified). We were relying on it raising a `ValueError` in this case. This fix should keep dask's interface consistent across Python versions. Signed-off-by: Adam Williamson <awilliam@redhat.com>
In Python 3.13, it is not any more: https://docs.python.org/3.13/whatsnew/3.13.html#other-language-changes "Compiler now strip indents from docstrings." Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Can one of the admins verify this patch? Admins can comment |
|
I didn't run |
|
Oh, forgot to mention, python/cpython#110274 is the reference for the exception type change upstream. |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 24m 21s ⏱️ + 1m 34s For more details on these failures, see this check. Results for commit 10f7321. ± Comparison against base commit f6e0690. |
fjetter
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesThis fixes two failures when running the test suite on Python 3.13.
dataclasses.replace()changed the type of the exception it raises in a couple of cases, one of which causes us to also raise a different exception type with a misleading message. We could adopt the same exception type change and just make sure we use the correct message, I guess, but that seems like an interface change, this keeps the behaviour the same as it was before.test_derived_from. We can fix it just by not expecting the indentation, I don't think we really need to enforce that it's there for older Python versions, we're just checking that our extra docstring text got in there, not policing indentation.