Unify column names in dd.read_csv #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
reviewed
Nov 1, 2016
| @@ -222,6 +222,17 @@ def test_enforce_columns(reader, blocks): | |||
| dask.compute(*dfs, get=get_sync) | |||
|
|
|||
|
|
|||
| def test_robust_column_mismatch(): | |||
There was a problem hiding this comment.
Slight nitpick - the test file is organized by functionality, might want to move this test down to below https://github.com/dask/dask/pull/1740/files#diff-62d83a5db4152149463203311f3d8b00R269?
There was a problem hiding this comment.
Ah, thanks for the nit. I appreciate such organization myself. Fixed.
|
Overall this seems fine to me. I can see the use case for normalizing column names across files where they might not match. |
mrocklin
force-pushed
the
dd.read_csv-columns
branch
from
c801c71
to
7a90ec7
Compare
Perhaps we should do this somewhere more globally? Perhaps we shouldn't do this at all?
mrocklin
force-pushed
the
dd.read_csv-columns
branch
from
7a90ec7
to
3827e31
Compare
3 tasks
jsignell
added a commit
that referenced
this pull request
Aug 5, 2021
Reverts #1740 to make it so that when files have different columns, those column names are not overwritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps we should do this somewhere more globally?
Perhaps we shouldn't do this at all?
cc @jcrist thoughts on how to improve? Should we remove?