COMPAT: Pandas 0.23 duplicate names in MI #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas 0.23 is disallowing duplicate names in MultiIndexes. This adjusts a test that relied on that behavior, and `groupby().nunique` which produced it as a by-product. Closes dask#3039 xref pandas-dev/pandas#18882
|
All the tests have passed. Pandas is considering turning this into a warning for 0.23 pandas-dev/pandas#19029, but we'll want to update anyway. cc @jcrist if you have a chance to look over this. |
jcrist
reviewed
Jan 2, 2018
dask/dataframe/groupby.py
Outdated
| # https://github.com/pandas-dev/pandas/pull/18882 | ||
| names = [None] * df.index.nlevels | ||
| result = df.drop_duplicates().rename_axis(names) | ||
| return result |
There was a problem hiding this comment.
Nit: just return instead of assign -> return. Also, rename_axis copies the data by default, when I don't think we need to here.
return df.drop_duplicates().rename_axis(names, copy=False)
|
All green, merging since this is blocking master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 0.23 is disallowing duplicate names in MultiIndexes. This
adjusts a test that relied on that behavior, and
groupby().nuniquewhichproduced it as a by-product.
Closes #3039
xref pandas-dev/pandas#18882
flake8 daskdocs/source/changelog.rstfor all changesand one of the
docs/source/*-api.rstfiles for new API