New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask dataframe isna #3294
Merged
Merged
Dask dataframe isna #3294
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a3fc478
added top level isna method to dask.dataframe
cr458 7f11231
test for isna
cr458 4f3df24
whitespace
cr458 214d5a5
changed init file to import isna method
cr458 48ea054
version dependent test
cr458 a69e797
skip test if version < 0.22.0
cr458 0de127a
try import for earlier versions of pandas
cr458 003ff99
line
cr458 fb973c0
newline
cr458 58a04b7
fixed hasattr call
cr458 0b366e2
Merge branch 'master' of github.com:cr458/dask into dask_dataframe_isna
cr458 f9617ef
update changelog
cr458 2f71e0a
isna method for _Frame
cr458 7e34482
Merge branch 'master' into dask_dataframe_isna
mrocklin c0fc19f
flake8
mrocklin 0fcc5f5
[skip ci] add isna to dataframe docs
mrocklin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrocklin, should this use the
hasattr
method of checking for theisna
instead? Just occurred to me thatisna
could be deprecated in future versions of pandas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't worry about isna being deprecated.