Fix env None check #3562
Merged
Fix env None check #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm, indeed. Thank you for catching this. If you have time it would be useful to establish a simple test to ensure that this kind of thing doesn't happen again. |
mrocklin
reviewed
Jun 6, 2018
| yaml.dump(b, f) | ||
|
|
||
| config = collect([fn1, fn2], env=env) | ||
| assert config == expected |
There was a problem hiding this comment.
Hrm, I think that in order to test the if env is None case we probably need to pass None in, and modify os.environ directly
def test_env_none():
os.environ['DASK_FOO'] = 'bar'
try:
config = collect([])
assert config['foo'] == 'bar'
finally:
del os.environ['DASK_FOO']
|
Looks good to me. Merging. Thanks for identifying and resolving this @sjperkins ! |
convexset
added a commit
to convexset/dask
that referenced
this pull request
Jun 12, 2018
* master: [array.linalg.qr] added sfqr (short-and-fat) as a counterpart to tsqr… (dask#3575) Drop Dask Array's `learn` module (dask#3580) Adds `isneginf` and `isposinf` (dask#3581) Update sizeof definitions (dask#3582) BUG: do not raise IndexError for identity slice in array.vindex (dask#3559) Correct internal dimension of Dask's SVD (dask#3517) Fix check in configuration with env=None (dask#3562) Dataframe sample method docstring fix (dask#3566) Include "region" in key names for da.store (dask#3540) # Conflicts: # dask/array/linalg.py # dask/array/tests/test_linalg.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
if os is Nonecheck is invalid, changing it toif env is None.flake8 dask