Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added index column name after resample (issue #3827) #3833

Merged

Conversation

eric-bonfadini
Copy link
Contributor

@eric-bonfadini eric-bonfadini commented Jul 31, 2018

This fixes #3827
Fixes #3660

I added the test mentioned in the issue in dask/dataframe/tseries/tests/test_resample.py

  • Tests added / passed
  • Passes flake8 dask

@TomAugspurger
Copy link
Member

Does this also close #3660?

@eric-bonfadini
Copy link
Contributor Author

@TomAugspurger yes, I ran both the snippets reported in that issue without errors.
Thanks for pointing out!

print(ddf2.compute().resample('1min').mean())
                        data1     data2
time                                   
1980-01-01 00:00:00  0.093619  0.006039
1980-01-01 00:01:00 -1.698607  0.146224
1980-01-01 00:02:00  0.603537  0.514630
1980-01-01 00:03:00 -1.207392  0.161776
1980-01-01 00:04:00 -1.089236 -0.329725
...

print(ddf2.resample('1min').mean().compute())
                        data1     data2
time                                   
1980-01-01 00:00:00  0.093619  0.006039
1980-01-01 00:01:00 -1.698607  0.146224
1980-01-01 00:02:00  0.603537  0.514630
1980-01-01 00:03:00 -1.207392  0.161776
1980-01-01 00:04:00 -1.089236 -0.329725
...

@TomAugspurger
Copy link
Member

Ok, thanks!

@TomAugspurger TomAugspurger merged commit 712ba26 into dask:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resample Dask Dataframe results in loss of index column name Bug writing to parquet
2 participants