Trim no expand #3950
Closed
Trim no expand #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might as well deprecate |
|
I'm not sure I like this implementation. It really clutters the That |
This was referenced Sep 5, 2018
|
Closed in favour of #3964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3947
Pushes the trimming logic for the boundary conditions into
chunk.trimallowing trim to be performed in an efficient manner even in the case where the boundary is'none'(string 'none')It should give more optimal performance from trim in the case where the boundary condition is string
'none'as it avoids calls to concatenate.flake8 dask