[WIP] Add k arg to diag #5683
Closed
[WIP] Add k arg to diag #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to work now, cleaned out comments. da.diagonal remains broken however.
|
This reuses code from @TomAugspurger is that clear? Please let me know if something is still unclear |
|
That makes sense, thanks. I looked into #5661, but didn't make much
progress.
…On Thu, Feb 6, 2020 at 8:46 AM Tobias de Jong ***@***.***> wrote:
This reuses code from da.diagonal in da.diag. The test that fails here,
fails because of the issue described in #5661
<#5661>, as test_corrcoef() calls
da.diag, which since this pull request calls da.diagonal, exposing the
bug described in #5661 <#5661>. In
principle this code can be merged, except that the test now fails because
of #5661 <#5661>.
@TomAugspurger <https://github.com/TomAugspurger> is that clear? Please
let me know if something is still unclear
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5683?email_source=notifications&email_token=AAKAOIXDQDYTLKUAJ65YH53RBQPDFA5CNFSM4JWCRU5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK7PAJA#issuecomment-582938660>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIUC73JVH6R344YU6EDRBQPDFANCNFSM4JWCRU5A>
.
|
|
@TomAugspurger , were you working on ironing things out here? |
|
Last I looked this is hitting an issue in another dask.array method. I'm
not currently working on it.
…On Tue, Apr 7, 2020 at 1:36 PM Martin Durant ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> , were you working on
ironing things out here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5683 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIWV4OCS5WUMBREFRELRLNXDLANCNFSM4JWCRU5A>
.
|
3 tasks
|
Superseded by #8689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2726 and reduces some code duplication by calling
da.diagonalwhere applicable. This for now breaks by #5661, therefore the WIP, although I don't feel equipped or have the time to solve that issue here.black dask/flake8 dask