New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly support dd.Index in setitem #5703
base: main
Are you sure you want to change the base?
Conversation
We don't want to align these.
I updated I updated |
This sounds like a good idea to me if you have the time. No expectations though if the cost/benefit ratio isn't high enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks
Co-Authored-By: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-Authored-By: James Bourbeau <jrbourbeau@users.noreply.github.com>
The short version is we have task names like
but I haven't figured out why yet, or what the old names were. |
We should probably just include the old token (or the old dataframe) within the tokenize call when we generate the new token. Having multiple tokens lying around is probably a bad idea. |
We don't want to align these. It has the same semantics as setting a dask array: we validate that the number of blocks match the number of partitions, and assume that the size of each block / partition matches.
This is a bit light on tests at the moment for invalid input (since we're re-using the dask.array implementation).
Closes #5702
cc @AlbertDeFusco