Remove u string prefixes #6633
Merged
Remove u string prefixes #6633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The u string prefixes are necessary on python 2 to indicate unicode strings. On Python 3, all strings are unicode strings and the u prefixes are not needed anymore. The changes were done using manual search and replace. modified: dask/bag/core.py modified: dask/bytes/tests/test_s3.py modified: dask/dataframe/hyperloglog.py modified: dask/dataframe/io/hdf.py modified: dask/dataframe/tests/test_format.py modified: dask/tests/test_base.py modified: dask/utils.py modified: docs/source/conf.py
Black seems to complain about the eager change
|
Thank you @rahulporuri ! Also, I notice that this is your first code contribution to this repository. Welcome! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
The u string prefixes are necessary on python 2 to indicate unicode strings. On Python 3, all strings are unicode strings and the u prefixes are not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
u"..."string prefixes are necessary on python 2 to indicate unicode strings. On Python 3, all strings are unicode strings and theu"..."prefixes are not needed anymore. The changes were done using manual search and replace.black dask/flake8 dask