New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify has_parallel_type() #6927
Conversation
I think this is ok. @mrocklin do you think this will adversely affect GeoPandas users ? My guess is no -- GeoPandas is the only the library (aside from cuDF) I am familiar with which extends dask dataframes |
def parallel_types(): | ||
return tuple( | ||
k | ||
for k, v in get_parallel_type._lookup.items() | ||
if v is not get_parallel_type_object | ||
) | ||
@get_parallel_type.register(object) | ||
def get_parallel_type_object(_): | ||
return Scalar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitley like your solution better. Do you think there is any need for a get_parallel_type
test, or do you think the functionality is covered elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be covered in all the has_parallel_type()
and new_dd_object()
tests
I like the simplification here, but can you explain how it helps down-stream projects? (Sorry if this is a silly question) |
This change depend on <dask/dask#6927>
The semantic of |
My fault should have been more clear. PS: The device memory spilling in Dask-CUDA makes use of this PR here: rapidsai/dask-cuda@8b977b7 |
This change depend on <dask/dask#6927>
@mrocklin @jrbourbeau, if any of you have time to review this, it would be great. It is currently blocking rapidsai/dask-cuda#451 |
This change depend on <dask/dask#6927>
This change depend on <dask/dask#6927>
This change depend on <dask/dask#6927>
This change depend on <dask/dask#6927>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madsbk! Apologies for the delayed
review
No worries :) |
This change depend on <dask/dask#6927>
This PR simplify the implementation of
has_parallel_type()
and make it easy to extend by down stream projects like rapidsai/dask-cuda#451black dask
/flake8 dask