Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added product (alias of prod) #7517

Merged
merged 5 commits into from Apr 5, 2021
Merged

Added product (alias of prod) #7517

merged 5 commits into from Apr 5, 2021

Conversation

freyam
Copy link
Contributor

@freyam freyam commented Apr 4, 2021

  • Tests added / passed
  • Passes black dask / flake8 dask / isort dask

@freyam
Copy link
Contributor Author

freyam commented Apr 4, 2021

I ran the tests locally (py.test dask/dataframe) after adding product() and they all PASSED ✔️

@martindurant
Copy link
Member

Thanks for contributing. Looks good to me.

This does not "Close #1259", which has potentially several methods to implement - please remove this from the PR description.

Note that pd.DataFrame.product is pd.DataFrame.prod - I think you mentioned this in the connected issue.

@freyam
Copy link
Contributor Author

freyam commented Apr 5, 2021

Removed "Closes #1259" from the PR.

and yes, pd.DataFrame.product is pd.DataFrame.prod indeed! So, aliasing also worked!
Now, I ill pick up some other methods like axes or duplicated from #1259 and work on them

@martindurant martindurant merged commit 8466409 into dask:main Apr 5, 2021
@freyam
Copy link
Contributor Author

freyam commented Apr 5, 2021

Yayyy 🚀

This was my first contribution to Dask!!
Thank you @martindurant for the quick review. This shall also help in my GSoC application. Now, I shall continue adding more methods #1259.

@martindurant
Copy link
Member

This was my first contribution to Dask!!

Congratulations and welcome!

@freyam freyam deleted the add-product branch April 5, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants