Adjust retrieving _max_workers from Executor
#8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Planning on merging end of day tomorrow if no comments. |
jrbourbeau
reviewed
Oct 7, 2021
There was a problem hiding this comment.
Thanks @jakirkham! Since this is a subtle point, could you add a test or comment explaining why this is needed? Otherwise this might get unintentionally reverted in the future
jakirkham
force-pushed
the
use_mpi4py_max_workers
branch
from
b952abe
to
aae536b
Compare
The `mpi4py` implementation will return `None` if it can't give a specific number. So this adjusts how `_max_workers` is retrieved to set it to `None` if it can't be figured out. Then if it is `None`, it will fallback to `dask.config`.
jakirkham
force-pushed
the
use_mpi4py_max_workers
branch
from
aae536b
to
6282398
Compare
|
Sure have done both Since this is content within the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mpi4pyimplementation will returnNoneif it can't give a specific number. So this adjusts how_max_workersis retrieved to set it toNoneif it can't be figured out. Then if it isNone, it will fallback todask.config.xref: mpi4py/mpi4py#94
xref: mpi4py/mpi4py#117
black dask/flake8 dask/isort dask