Enforce boolean ascending
for sort_values
#8440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass a list of ascending booleans to
sort_values
, which is not yet supported by_calculate_divisions
(which computes divisions in ascending order), and can cause undefined behavior.This small PR adds a check that ascending is a boolean before calling
rearrange_by_divisions
; note that this check happens after all single-partition cases are handled, as Pandas can handle lists of ascending booleans.pre-commit run --all-files