Pandas compat: Filter sparse warnings #8621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Thanks @jsignell. This seems like a reasonable workaround -- let's continue to watch the upstream pandas issue. Also cc @jorisvandenbossche for visibility
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
| @@ -86,6 +86,9 @@ def test_get_dummies_kwargs(): | |||
| tm.assert_index_equal(res.columns, pd.Index([1, 2, 3, 5, np.nan])) | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings( | |||
| "ignore:In a future version, passing a SparseArray:FutureWarning" | |||
| ) # https://github.com/pandas-dev/pandas/issues/45618 | |||
There was a problem hiding this comment.
I find it a bit strange that this ignore is needed, as the example shouldn't be dealing with a sparse dtype in the index, only sparse columns.
There was a problem hiding this comment.
Ah, I see that's exactly why you opened the pandas issue :) pandas-dev/pandas#45618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these warnings should not be cropping up from pandas, so this PR just filters them out.