specify dtype when deciding division using np.linspace in read_sql_query #8940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files
The current logic on deciding the
divisions
indd.read_sql_query
will result in afloat
array by default, without any possible way of specifying thedtype
that we want, that is generally bad when filtering on the usualinteger
index of a sql database.Fix:
Specifying the
dype
innp.linspace
so that thedivisions
array will be the samedtype
as thelimits
or theindex_col
.