Avoid checking the returned sqlite dtype on all 32 bit platforms. #9427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still some 32-bit linux targets in addition to win32.
|
Can one of the admins verify this patch? Admins can comment |
jsignell
reviewed
Aug 25, 2022
| @@ -440,7 +440,7 @@ def test_query_with_meta(db): | |||
| ).select_from(sql.table("test")) | |||
| out = read_sql_query(s1, db, npartitions=2, index_col="number", meta=meta) | |||
| # Don't check dtype for windows https://github.com/dask/dask/issues/8620 | |||
| assert_eq(out, df[["name", "age"]], check_dtype=sys.platform != "win32") | |||
| assert_eq(out, df[["name", "age"]], check_dtype=sys.int_info.sizeof_digit != 2) | |||
There was a problem hiding this comment.
Should this be:
Suggested change
| assert_eq(out, df[["name", "age"]], check_dtype=sys.int_info.sizeof_digit != 2) | |
| assert_eq(out, df[["name", "age"]], check_dtype=sys.int_info.sizeof_digit != 32) |
There was a problem hiding this comment.
It definitely should be 2. (I think it's size in bytes.)
On a 32 bit linux system with python 3.9.2 I get:
python3 -c "import sys; print(sys.int_info)"
sys.int_info(bits_per_digit=15, sizeof_digit=2)on the 32 bit windows version of python 3.10.6 running under the 32 bit wine (5.0.3) I get:
wine python.exe -c "import sys; print(sys.int_info)"
sys.int_info(bits_per_digit=15, sizeof_digit=2)And on a 64 bit linux system with python 3.10.6 I get
python3 -c "import sys; print(sys.int_info)"
sys.int_info(bits_per_digit=30, sizeof_digit=4)
|
ok to test |
github-actions
bot
added
the
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some 32-bit linux targets in addition to win32.
read_sql_querywith meta converts dtypes from 32 to 64. #8620 It's really more of a work around, the problem of sqlite's data types not being consistent between 64 and 32 bit architectures is not fixed. This patch ignores that difference because it's pretty likely to not be that important.(test_query_with_meta was made slightly weaker on 32-bit architectures by not requiring the same dtype)
pre-commit run --all-filesI made the patch pushed it to my own branch on github and waited for the tests to run. There's (now) one test failure that looks unrelated to this change. I think that's equivalent to the pre-commit run --all-files
(On my first try I typoed the name of int_info and there were two test failures, so I'm pretty sure the test is actually running.)