Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore zero sized chunks in auto_chunks #9444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jasonkena
Copy link

@jasonkena jasonkena commented Aug 30, 2022

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

When an array is interspersed with empty chunks, the zero-valued chunks skew the median; this accounts for that while maintaining original behavior if the array only contains empty chunks.

Test cases are yet to be added.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions github-actions bot added the array label Aug 30, 2022
@jasonkena jasonkena closed this Aug 31, 2022
@jasonkena jasonkena reopened this Aug 31, 2022
@pavithraes pavithraes self-requested a review August 31, 2022 13:19
@pavithraes
Copy link
Member

ok to test

@pavithraes pavithraes removed their request for review August 31, 2022 15:54
@ncclementi
Copy link
Member

@jasonkena Do you have a reproducible example that we can run to see how this behaved before and after the change?
Similarly, would you mind adding a test for this new behavior? I see we have two path codes (if/else) and we should cover both of them.

@github-actions github-actions bot added the needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants