Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization bug in BroadcastJoinLayer #9871

Merged
merged 3 commits into from Jan 26, 2023
Merged

Fix serialization bug in BroadcastJoinLayer #9871

merged 3 commits into from Jan 26, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Jan 24, 2023 •
edited

The current logic used to serialize a BroadcastJoinLayer object does not work when left_on and/or right_on are lists. The simple fix used here is to always covert these arguments from lists to tuples.

@rjzamora rjzamora added dataframe highlevelgraph Issues relating to HighLevelGraphs. bug Something is broken labels Jan 24, 2023
ayushdg
ayushdg approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I've confirmed this fixes the repro in the issue as well as my workflow usecase.

@j-bennet
Copy link
Contributor

@rjzamora This looks good, are you waiting on something to merge?

@rjzamora
Copy link
Member Author

Thanks for taking a look @ayushdg and @j-bennet ! Will merge after CI

@rjzamora rjzamora changed the title Fix serialization bug in BroadcastJoinLayer Fix serialization bug in BroadcastJoinLayer Jan 26, 2023
@rjzamora rjzamora merged commit 3f8d092 into dask:main Jan 26, 2023
@rjzamora rjzamora deleted the fix-bcast-serialize branch January 26, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg ayushdg approved these changes

Assignees
No one assigned
Labels
bug Something is broken highlevelgraph Issues relating to HighLevelGraphs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broadcast join fails when passing a list of columns to merge on
3 participants
@rjzamora @j-bennet @ayushdg