Skip to content

Commit

Permalink
Docs
Browse files Browse the repository at this point in the history
  • Loading branch information
hendrikmakait committed Aug 17, 2023
1 parent 7283a56 commit 8251678
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions distributed/shuffle/_core.py
Expand Up @@ -285,16 +285,16 @@ def create_new_run(
def _pin_output_workers(

Check warning on line 285 in distributed/shuffle/_core.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_core.py#L284-L285

Added lines #L284 - L285 were not covered by tests
self, plugin: ShuffleSchedulerPlugin
) -> dict[_T_partition_id, str]:
"""TODO"""
"""Pin output tasks to workers and return the mapping of partition ID to worker."""

@abc.abstractmethod
def initialize_run_on_worker(
def create_run_on_worker(

Check warning on line 291 in distributed/shuffle/_core.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_core.py#L290-L291

Added lines #L290 - L291 were not covered by tests
self,
run_id: int,
worker_for: dict[_T_partition_id, str],
plugin: ShuffleWorkerPlugin,
) -> ShuffleRun:
"""TODO"""
"""Create the new shuffle run on the worker."""


@dataclass(eq=False)
Expand Down
2 changes: 1 addition & 1 deletion distributed/shuffle/_rechunk.py
Expand Up @@ -463,7 +463,7 @@ def _pin_output_workers(self, plugin: ShuffleSchedulerPlugin) -> dict[NDIndex, s
self.id, parts_out, _get_worker_for_hash_sharding
)

def initialize_run_on_worker(
def create_run_on_worker(

Check warning on line 466 in distributed/shuffle/_rechunk.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_rechunk.py#L466

Added line #L466 was not covered by tests
self,
run_id: int,
worker_for: dict[NDIndex, str],
Expand Down
2 changes: 1 addition & 1 deletion distributed/shuffle/_shuffle.py
Expand Up @@ -502,7 +502,7 @@ def _pin_output_workers(self, plugin: ShuffleSchedulerPlugin) -> dict[int, str]:
pick_worker = partial(_get_worker_for_range_sharding, self.npartitions)
return plugin._pin_output_workers(self.id, self.parts_out, pick_worker)

Check warning on line 504 in distributed/shuffle/_shuffle.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_shuffle.py#L500-L504

Added lines #L500 - L504 were not covered by tests
def initialize_run_on_worker(
def create_run_on_worker(
self, run_id: int, worker_for: dict[int, str], plugin: ShuffleWorkerPlugin
) -> ShuffleRun:
return DataFrameShuffleRun(

Check warning on line 508 in distributed/shuffle/_shuffle.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_shuffle.py#L506-L508

Added lines #L506 - L508 were not covered by tests
Expand Down
2 changes: 1 addition & 1 deletion distributed/shuffle/_worker_plugin.py
Expand Up @@ -288,7 +288,7 @@ async def _(

self.worker._ongoing_background_tasks.call_soon(_, self, existing)

shuffle: ShuffleRun = result.spec.initialize_run_on_worker(
shuffle: ShuffleRun = result.spec.create_run_on_worker(

Check warning on line 291 in distributed/shuffle/_worker_plugin.py

View check run for this annotation

Codecov / codecov/patch

distributed/shuffle/_worker_plugin.py#L291

Added line #L291 was not covered by tests
result.run_id, result.worker_for, self
)
self.shuffles[shuffle_id] = shuffle
Expand Down

0 comments on commit 8251678

Please sign in to comment.