Faulty assert in Worker.transition_waiting_ready

[TomAugspurger]

I think the assertion in

distributed/distributed/worker.py

Line 1464 in d378b41

assert key not in self.ready

is never true. self.ready will have priorities. Adding some logging

                logger.warning('############# %s %s', key, self.ready)

ouptuts

43 distributed.worker[30125] WARNING ############# <lambda>-3cc7458434b76e085f60ee2b4b3dc161 [((0, 1, 1, 0), '<lambda>-77595a333c06d570fabf39dd72c3f0e5'), ((0, 1, 3, -1), '<lambda>-3d83e26cf6671e58568f01886987f38b'), ((0, 1, 5, -2), '<lambda>-e71accaf49023ba14850f58f99f5b81b')]

[mrocklin]

Ah, interesting point. We could either ignore that or do a more expensive check. I don't have a strong preference.

[martindurant]

@TomAugspurger , did you mean to fix this?

[TomAugspurger]

Nope. Not a priority for me. Fixing it would I think require an O(N) step to extract the key from the priorities `set(x[0] for x in self.priority)`. Not sure if that's too expensive when `validate=True`.

…

On Wed, Jun 19, 2019 at 1:10 PM Martin Durant ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> , did you mean to fix this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2763?email_source=notifications&email_token=AAKAOIVHSZLR723UYTEH6YDP3JZDDA5CNFSM4HWWLJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCWPKQ#issuecomment-503670698>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIUFAIAXJXDXIEFV3LTP3JZDDANCNFSM4HWWLJEQ> .

[martindurant]

So it would be more correct to say that the validate=True branch is not tested or called anywhere?

[TomAugspurger]

I imagine it's tested. It's just that the `assert` is vacuously true since we're doing something like `assert 'a' not in [('b', 0), ('c', 1)]`, when we want `assert 'a' not in ['b', 'c']`.

…

On Wed, Jun 19, 2019 at 1:16 PM Martin Durant ***@***.***> wrote: So it would be more correct to say that the validate=True branch is not tested or called anywhere? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2763?email_source=notifications&email_token=AAKAOIWBX3AFYIOC3PX4OY3P3JZYNA5CNFSM4HWWLJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCW7QA#issuecomment-503672768>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIT6LZ4D6J3XAGK3F2DP3JZYNANCNFSM4HWWLJEQ> .