Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in test_oversubscribing_leases #3717

Closed
mrocklin opened this issue Apr 16, 2020 · 5 comments · Fixed by #3720 or #3726
Closed

Test failure in test_oversubscribing_leases #3717

mrocklin opened this issue Apr 16, 2020 · 5 comments · Fixed by #3720 or #3726

Comments

@mrocklin
Copy link
Member

This showed up in a recent PR. I copy-pasted the traceback and then restarted the job.
Unfortunately my attempt to copy-paste the trace turned out to be incomplete. My apologies. Hopefully this helps though.

cc @fjetter

>   assert not sem.acquire(timeout=0.05)
E   assert not True
E    +  where True = <bound method Semaphore.acquire of <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>>(timeout=0.05)
E    +    where <bound method Semaphore.acquire of <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>> = <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>.acquire

distributed\tests\test_semaphore.py:396: AssertionError
---------------------------- Captured stderr call -----------------------------
distributed.worker - WARNING -  Compute Failed
Function:  observe_state
args:      ()
kwargs:    {'sem': <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>}
Exception: AssertionError('assert not True\n +  where True = <bound method Semaphore.acquire of <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>>(timeout=0.05)\n +    where <bound method Semaphore.acquire of <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>> = <distributed.semaphore.Semaphore object at 0x0000027BF23DE438>.acquire',)
@mrocklin
Copy link
Member Author

It's coming up here as well. (I didn't restart the job this time)

https://github.com/dask/distributed/pull/3650/checks?check_run_id=593854022

Pinging also @lr4d

@fjetter
Copy link
Member

fjetter commented Apr 17, 2020

Looking into it

@mrocklin
Copy link
Member Author

mrocklin commented Apr 17, 2020 via email

@mrocklin
Copy link
Member Author

I think that this is still happening. I reran these tests about an hour ago, which I think is after the recent merge of #3720

https://github.com/dask/distributed/pull/3650/checks?check_run_id=596031832

@lr4d
Copy link
Contributor

lr4d commented Apr 18, 2020

@mrocklin in the traceback I see > assert not sem.acquire(timeout=0.05), whereas this was changed in #3720 at https://github.com/dask/distributed/pull/3720/files#diff-dee863c4f303f33e8e88eb708f00130bL396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants