Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml for configuration? #5725

Open
jrbourbeau opened this issue Jan 28, 2022 · 4 comments
Open

Use pyproject.toml for configuration? #5725

jrbourbeau opened this issue Jan 28, 2022 · 4 comments

Comments

@jrbourbeau
Copy link
Member

In #5720 @ian-r-rose and @gjoseph92 brought up switching some (maybe all?) of our various tool configuration (e.g. pytest) from setup.cfg to a pyproject.toml file. Some projects, e.g. pytest, explicitly recommend against using a setup.cfg file in favor of other configuration files like pyproject.toml https://docs.pytest.org/en/6.2.x/customize.html#setup-cfg. I'm not familiar with pyproject.toml so can't speak to various pros and cons -- opening up an issue to see if there's interest in using pyproject.toml

@fjetter
Copy link
Member

fjetter commented Jan 28, 2022

@bryanwweber
Copy link
Contributor

Flake8 does not, and has no plans, to support pyproject.toml: PyCQA/flake8#234 (unfortunately, that thread was migrated from GitLab and is very difficult to follow). Anyhow, Anthony has been very clear that Flake8 has no plans to support pyproject.toml now or in the future 🤷

@ian-r-rose
Copy link
Collaborator

I'd be in favor of moving things to a pyproject.toml that support it. It seems to be the preferred format for most (but not all) newer tooling. As a bit of a carrot, it could also help to remove a vendored versioneer and use versioneer-518.

For what it's worth, Anthony is also against it for pre-commit: pre-commit/pre-commit#1165

@fjetter
Copy link
Member

fjetter commented Feb 1, 2022

For what it's worth, Anthony is also against it for pre-commit: pre-commit/pre-commit#1165

Makes sense. I agree that yaml is a better format for pre-commit.

FWIW, I personally prefer toml and yaml over ini but between toml and yaml this is a tough call and likely application specific. The better file format is also what motivates me more than having all config in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants