New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non-test directories #5720
Conversation
Superscedes dask#5719
I like this solution over doing things like |
Good point about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today we use setup.cfg
for this type of configuration. I don't know much about pyproject.toml
, there may be good reasons for preferring it over setup.cfg
, but I'd prefer not to split configuration between both pyproject.toml
and setup.cfg
files. For the time being could you update
Lines 41 to 42 in dbc5b0f
[tool:pytest] | |
addopts = -v -rsxfE --durations=20 --color=yes |
instead?
pyproject.toml
Outdated
@@ -0,0 +1,2 @@ | |||
[tool.pytest.ini_options] | |||
addopts = "--ignore=continuous_integration --ignore=docs --ignore=.github" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not testing code snippets in the docs today, but wanted to flag that --ignore=docs
may need to be removed if we want to start that level of testing
|
That's good to know. Does adding these ignores to our existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjoseph92! This should be good to merge once CI finishes up
Also, I opened #5725 to follow up on moving to pyproject.toml
Supersedes #5719. This does make
pyetst
work on the root distributed directory.cc @ian-r-rose @jrbourbeau
pre-commit run --all-files