New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bokeh an optional install requirement #7363
Comments
Seems reasonable to me to move the |
@jrbourbeau any more thoughts here? This still seems like a pain point #7512 |
I would argue this is still the case. There is typically no point in installing
@gabicca you can install what you want by simply installing |
Hi @fjetter , I still disagree with this approach. It feels backwards. You're right, dask will be installed if you install distributed, because it's in distributed's requirements. But you can't specify if you want any optional requirements installed like that, because distributed doesn't have the right settings to give it optionals. You say: "There is typically no point in installing distributed as a standalone since it will inevitably install dask as well." This doesn't really make sense. If you need distributed, then you should just install distributed and not specify dask as your dependency, since distributed will install it anyway. But now, if I want distributed with diagnostics (since really, that's a distributed feature and not, or not just, a dask feature), you can't just make it your dependency, because now you explicitly have to add dask[diagnostics] as well, sintead of just adding distributed[diagnostics] and not worry about dask anymore. Sorry for the convoluted message, hopefully what I'm trying to say here gets across. At the moment the only way we could solve this is add Again, the main problem here, is that the |
dask/distributed#7363 would be nice here; pedantically, it's improper packaging practice to not have the extra directly in `distributed`.
At the moment distributed does not include bokeh in its requirements at all. But it contains features that break without it. I'd like to ask that you include bokeh as optional requirement in your package, so that users can easily install everything they need.
Since distributed uses setup.py, you can do this by adding it to
extras_require
(https://extras-require.readthedocs.io/en/latest/).The text was updated successfully, but these errors were encountered: