Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test_shuffle.py::test_flaky_connect_recover_with_retry #8555

Closed
crusaderky opened this issue Mar 5, 2024 · 0 comments · Fixed by #8556
Closed

Flaky test_shuffle.py::test_flaky_connect_recover_with_retry #8555

crusaderky opened this issue Mar 5, 2024 · 0 comments · Fixed by #8556
Assignees
Labels
bug Something is broken flaky test Intermittent failures on CI. regression shuffle tests Unit tests and/or continuous integration

Comments

@crusaderky
Copy link
Collaborator

crusaderky commented Mar 5, 2024

This test is very flaky:
3 out of 11 runs failed: test_flaky_connect_recover_with_retry (distributed.shuffle.tests.test_shuffle)

e.g. https://github.com/dask/distributed/actions/runs/8156647196/job/22294610970?pr=8551

>       assert len(logs) < 600
E       AssertionError: assert 656 < 600
E        +  where 656 = len('Retrying <function ShuffleRun.send.<locals>._send at 0x7fa57efcb4c0> after exception in attempt 0/1: Timed out trying to connect to tcp://127.0.0.1:37919 after 0 s\nRetrying <function ShuffleRun.send.<locals>._send at 0x7fa56eb03160> after exception in attempt 0/1: Timed out trying to connect to tcp://127.0.0.1:37919 after 0 s\nRetrying <function ShuffleRun.send.<locals>._send at 0x7fa57d0ba700> after exception in attempt 0/1: Timed out trying to connect to tcp://127.0.0.1:38667 after 0 s\nRetrying <function ShuffleRun.send.<locals>._send at 0x7fa57d576670> after exception in attempt 0/1: Timed out trying to connect to tcp://127.0.0.1:38667 after 0 s\n')

This is a regression introduced in #8511.
CC @hendrikmakait

@crusaderky crusaderky added bug Something is broken flaky test Intermittent failures on CI. tests Unit tests and/or continuous integration shuffle regression labels Mar 5, 2024
@hendrikmakait hendrikmakait self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken flaky test Intermittent failures on CI. regression shuffle tests Unit tests and/or continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants