Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_flaky_connect_recover_with_retry #8556

Conversation

hendrikmakait
Copy link
Member

Closes #8555

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait marked this pull request as draft March 5, 2024 16:43
@hendrikmakait hendrikmakait marked this pull request as ready for review March 5, 2024 17:38
Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks @hendrikmakait!

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   10h 15m 55s ⏱️ + 9m 9s
 4 048 tests ±0   3 935 ✅ ±0    110 💤 ±0  2 ❌  - 1  1 🔥 +1 
50 829 runs  +1  48 531 ✅ +3  2 295 💤 +1  2 ❌  - 4  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit c6ce3bb. ± Comparison against base commit bec6ea5.

@hendrikmakait hendrikmakait merged commit b1597b6 into dask:main Mar 5, 2024
30 of 34 checks passed
@hendrikmakait hendrikmakait deleted the fix-test_flaky_connect_recover_with_retry branch March 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_shuffle.py::test_flaky_connect_recover_with_retry
2 participants