Remove Python 3.4 run from Travis-CI #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may help speed up builds a bit. Also remove the ASYNCIO environment variable which doesn't seem examined anywhere.
pitrou
commented
Jun 11, 2017
| @@ -41,6 +41,19 @@ | |||
| 'distributed.http'], | |||
| long_description=(open('README.rst').read() if os.path.exists('README.rst') | |||
| else ''), | |||
| classifiers=[ | |||
| "Development Status :: 5 - Production/Stable", | |||
There was a problem hiding this comment.
Perhaps I'm being optimistic?
There was a problem hiding this comment.
Seems fine to me. This seems project seems stable relative to most other projects.
mrocklin
reviewed
Jun 11, 2017
| - PYTHON=3.4 COVERAGE=true DASK_EXPERIMENTAL_ZMQ=1 | ||
| - PYTHON=3.5 CRICK=true ASYNCIO=true | ||
| - PYTHON=3.6 PACKAGES=blosc ASYNCIO=true | ||
| - PYTHON=3.5 COVERAGE=true PACKAGES=blosc CRICK=true DASK_EXPERIMENTAL_ZMQ=1 |
There was a problem hiding this comment.
No hard feelings from me. It we drop testing it, though, we can probably drop it from the code base as well. What do you think?
There was a problem hiding this comment.
I think it's value is in verifying that comms is extensible. However now that inproc exists that may suffice. I'm inclined to remove it just to reduce the codebase.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help speed up builds a bit.
Also remove the ASYNCIO environment variable which doesn't seem examined anywhere.
Also taking the liberty of adding
setup.pyclassifiers.