Fix Numba serialization when strides is None #3166
Conversation
|
The failure is unrelated to this PR. |
distributed/protocol/numba.py
Outdated
| itemsize = np.dtype(header["typestr"]).itemsize | ||
| strides = list(header["shape"][1:]) + [itemsize] | ||
| for i in range(len(strides) - 1, 0, -1): | ||
| strides[i - 1] *= strides[i] |
There was a problem hiding this comment.
You might want something like the following?
strides = np.cumprod(shape[::-1]) * itemsizeThere was a problem hiding this comment.
Why didn't this show up in tests? Don't we test with a C-contiguous array?
There was a problem hiding this comment.
Thanks for the suggestion, it's indeed what I wanted and couldn't think of when I wrote the code.
There are two reasons it didn't show up in the tests:
- CUDA code is not being tested by CI;
- Numba >= 0.46.0 is required (which contains version 2 of
__cuda_array_interface__.
|
Did Looks like the linting failure is real: https://travis-ci.org/dask/distributed/jobs/601702095#L491. |
|
Thanks @TomAugspurger, I hadn't seen the latest failure. The new commit should fix it, let's hope it's green now! |
|
Lint checks passed now, but CI failed again on unrelated tests. |
|
Thanks @pentschev ! Merging in. |
This is necessary for newer Numba versions with
__cuda_array_interface__version 2.The existing test fails for Numba 0.46.0, so this case is automatically covered, but I'm not sure if we can really have a specific test for this.
cc @quasiben @madsbk