Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate options to configuration #3258

Merged
merged 1 commit into from Nov 23, 2019
Merged

Add validate options to configuration #3258

merged 1 commit into from Nov 23, 2019

Conversation

mrocklin
Copy link
Member

No description provided.

@mrocklin mrocklin mentioned this pull request Nov 22, 2019
Closed
TomAugspurger
TomAugspurger approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very valuable for debugging.

@TomAugspurger
Copy link
Member

CI failure is distributed/tests/test_diskutils.py::test_workspace_concurrency, which I believe is unrelated.

jrbourbeau
jrbourbeau reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I've seen that failure occasionally before. Just restarted the failing build to see if it goes away

@mrocklin mrocklin merged commit bacfa51 into dask:master Nov 23, 2019
@mrocklin mrocklin deleted the make-validate-configurable branch November 23, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrocklin @TomAugspurger @jrbourbeau