Update latencies with heartbeats #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
reviewed
Dec 10, 2019
|
Other than the small comment about the |
fjetter
force-pushed
the
update_latency_on_workers
branch
from
b457905
to
52d9941
Compare
fjetter
force-pushed
the
update_latency_on_workers
branch
from
52d9941
to
17fa31d
Compare
|
Thanks! I'll merge once CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latency is currently only calculate once during connect. The heartbeat seemed to be a good periodic callback which could update this. Also the latency seems to be a good digest candidate, similar to the tick length