Skip test_open_close_many_workers on Python 3.6 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has caused intermittent failures in the past. Previously we had marked it as xfail, but it would still cause CI to break because it would cause things to hang. In dask#3419 it was observed that the failure seems to only occur on Python 3.6. This commit changes the universal xfail to a skipif for Python 3.6 and below. We still don't know what causes the failure, other than that GC seems to take up all of the CPU time Fixes dask#3419
bnaul
pushed a commit
to replicahq/distributed
that referenced
this pull request
Feb 10, 2020
This test has caused intermittent failures in the past. Previously we had marked it as xfail, but it would still cause CI to break because it would cause things to hang. In dask#3419 it was observed that the failure seems to only occur on Python 3.6. This commit changes the universal xfail to a skipif for Python 3.6 and below. We still don't know what causes the failure, other than that GC seems to take up all of the CPU time Fixes dask#3419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has caused intermittent failures in the past.
Previously we had marked it as xfail, but it would still cause CI to
break because it would cause things to hang.
In #3419 it was observed that the failure seems to only occur on Python
3.6. This commit changes the universal xfail to a skipif for Python 3.6
and below.
We still don't know what causes the failure, other than that GC seems to
take up all of the CPU time
Fixes #3419