gen_cluster forwards configuration to Nanny Workers #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow_nanny_cfg_ctx
jrbourbeau
reviewed
Dec 22, 2020
There was a problem hiding this comment.
Thanks @fjetter! I just merged the main branch to resolve some unrelated CI failures
|
ooops there are segfaults on travis https://travis-ci.org/github/dask/distributed/jobs/750955092 |
jrbourbeau
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Thanks for reporting over in #4387. The CI failures on Travis are also happening on master, so are not related to the changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed configuration in
gen_clusteris not forwarded to workers if a nanny is used. This makes testing sometimes quite surprising