Split RAM measure into dask keys/other old/other new #4651
Conversation
| @@ -361,6 +447,8 @@ class WorkerState: | |||
| _last_seen: double | |||
| _local_directory: str | |||
| _memory_limit: Py_ssize_t | |||
| _memory_other_history: "deque[tuple[float, Py_ssize_t]]" | |||
There was a problem hiding this comment.
sadly, Cython doesn't seem to support from __future__ import annotations yet; it would have made the quotes unnecessary.
There was a problem hiding this comment.
I think it will in Cython 3 ( cython/cython#3829 ). That's probably still a ways off though
|
@jacobtomlinson see how you like it now |
|
I see no change with that. Edit I tested on my 1920 x 1200 primary display and also saw no change, but 100/120 displayed well. |
|
I don't get it - this is how 1920x1080 looks like in my screen with 60px (using chrome dev tools):
is this a problem of you having a much larger font? |
|
@jacobtomlinson try now... |
|
No that also didn't do anything. I notice looking at yours that the plots don't have any axis labels. Can you try adding some workers and checking it again? I am just testing with |
|
retested height with the axis labels |
|
Perfect!
|
There was a problem hiding this comment.
Thanks for iterating with me on the status page @crusaderky.
Everything else looks good to me.
|
Let's get this in. It looks like all feedback has been addressed and it's been open for a while now. If there is anything outstanding we can tweak it in follow-up PRs. Thanks for your efforts here @crusaderky! |
|
Woo!
…On Tue, Apr 20, 2021 at 6:35 AM Jacob Tomlinson ***@***.***> wrote:
Merged #4651 <#4651> into main.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4651 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTGJKDJM3VSS4IORUMTTJVRILANCNFSM42BX522Q>
.
|
|
It looks like |
|
I'm onto it. It WAS working. :$ |
|
Fix in #4719 |
Fix for changes in dask/distributed#4651 Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #584
Closes #4634
DONE: backend
DONE: frontend
DONE: backend unit tests
DONE: frontend unit tests
DONE: stress testing
Out of scope (left to later PRs): use these measures in heuristics
Out of scope (left to later PRs): frontend design for >= 50 workers
Note: please switch to incognito mode or wipe your cache before testing this PR. If the dashboard from the main branch is in your browser's cache, bokeh will misbehave.