Print detail in validate_* assertions
#4933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When validation failed for whatever reason, I found myself wanting this (since pytest may not alway pretty-print these errors, if they happen to be caught by a try-except elsewhere in the scheduler for example).
jrbourbeau
reviewed
Jun 18, 2021
Comment on lines
+4790
to
+4792
| assert not any(ts in dts._waiters for dts in ts._dependencies), [ | ||
| dts._waiters for dts in ts._dependencies | ||
| ] |
There was a problem hiding this comment.
Should we also print ts (or ts.key) so we can parse the ts in dts._waiters part of this assert?
I have similar questions for all the other assert X in Y / assert X not in Y statements here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validation failed for whatever reason, I found myself wanting this (since pytest may not alway pretty-print these errors, if they happen to be caught by a try-except elsewhere in the scheduler for example).
black distributed/flake8 distributed/isort distributed