Add maximum shard size to config #4986
Conversation
| @@ -165,6 +165,7 @@ distributed: | |||
| min: 1s # the first non-zero delay between re-tries | |||
| max: 20s # the maximum delay between re-tries | |||
| compression: auto | |||
| shard: 64MiB | |||
There was a problem hiding this comment.
nitpick but the previous value was 64MB not 64MiB :)
There was a problem hiding this comment.
Fair point. I think that we should default to powers of two in general. Any objection?
There was a problem hiding this comment.
I think that we should default to powers of two in genera
I guess it doesn't really matter but with powers of two we probably have the best chance to hit some kind of sweet mem alignment/cache size/whatever optimization so I'm all for it.
However, if you prefer powers of two, you should use MB, shoudn't you? (I understand if you didn't want to push changes any more, just wondering if I messed something up in my mind :) )
MB == 1024 ** 2 / 2 ** 20
MiB == 1000 ** 2 / 10**6
There was a problem hiding this comment.
From the internet, the source of all truth.
Megabytes (MB) or Mebibytes (MiB)?
Though the article refers to Linux, the topic is applicable to all computers. ... According to these standards, technically a megabyte (MB) is a power of ten, while a mebibyte (MiB) is a power of two, appropriate for binary machines. A megabyte is then 1,000,000 bytes.Dec 23, 2001
There was a problem hiding this comment.
wow, I was wrong all those years. I remember a first semester class where my prof introduced the unit and I would've sworn all these years it was the other way round 🤦
There was a problem hiding this comment.
Maybe the prof was wrong too? Imagine how they feel :)
There was a problem hiding this comment.
If he was wrong, he'd never admit to it!
We ran into problems with websocket comms. Various parts of the web infrastructure that were outside of our control didn't want to pass frames larger than a few megabytes. Folks were changing this value by hand and pushing new versions of the software around. |
black distributed/flake8 distributed/isort distributed