WIP: worker environments #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Returns set of workers that fit the names/hosts/environments provided - Now works with environment names as well - Used most places where `self.coerce_address` was used before.
| workers.extend([host + ':' + port | ||
| for port in self.host_info[host]['ports']]) | ||
| # TODO replace with worker_list | ||
| workers = self.workers_set(workers) |
| @@ -1091,6 +1092,28 @@ def get_dataset(self, name): | |||
| return sync(self.loop, self._get_dataset, tokey(name)) | |||
|
|
|||
| @gen.coroutine | |||
| def _register_environment(self, name, env): | |||
| if not isinstance(env, Environment): | |||
| env = Environment(condition=env) | |||
There was a problem hiding this comment.
we could also do this with keyword arguments, like the following:
def register_environment(self, name, environment=None, condition=None):
...
|
Considering names for a moment. I'm colliding a bit here with the recent conda work that allows the client to upload conda environments for all of the workers to restart themselves in. This feature is unpublished and so can be easily renamed, but the current name is Thoughts on names for either of the two concepts currently called environments? |
|
This PR has gone stale. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Client.register_environmentupdates state on scheduler and workersClient.submitcan take environment names inworkers=