Set lower tick frequency in tests #5977
Conversation
|
@graingert it would be good to know if this alleviates the pain that you were seeing in #5908 if you have the time tomorrow |
distributed/utils_test.py
Outdated
| dask.config.set( | ||
| { | ||
| "distributed.comm.timeouts.connect": "5s", | ||
| "distributed.admin.tick.interval": "500 ms", | ||
| } | ||
| ) |
There was a problem hiding this comment.
This config setting is not side effect free, i.e. it doesn't reset itself properly afterwards. That causes tests to run with different configurations depending on the order of test execution.
I tried to fix it earlier but that causes many other failures. I'd prefer not adding more config params to this
There was a problem hiding this comment.
I was curious why we weren't using the context manager here. I'd be tempted to use it and see what happens. I'm going to push up a commit now to see what breaks. Probably I'm walking down a bad path, but we'll see what happens :)
There was a problem hiding this comment.
Tests seem happy here. Do you still have concerns? I wouldn't be surprised to learn that there was untested conflicts somewhere, but I'm hoping not :)
There was a problem hiding this comment.
if the tests are happy, I'm happy. this is how it is supposed to be after all
Possible alleviation of the pain mentioned in #5908