update celery and other outdated 3rd party URLs #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Mar 24, 2022
| .. _Dispy: http://dispy.sourceforge.net/ | ||
| .. _Pyro: https://pythonhosted.org/Pyro4/ | ||
| .. _Dispy: https://dispy.org/ | ||
| .. _Pyro: https://pyro4.readthedocs.io/ |
There was a problem hiding this comment.
should this be
Suggested change
| .. _Pyro: https://pyro4.readthedocs.io/ | |
| .. _Pyro: https://pyro5.readthedocs.io/ |
as pyro4 is eol now
graingert
commented
Mar 24, 2022
| @@ -72,14 +72,14 @@ There are a couple of older projects that often get mentioned | |||
| * Pyro_: Remote objects / RPC | |||
|
|
|||
| .. _Luigi: https://luigi.readthedocs.io/en/latest/ | |||
There was a problem hiding this comment.
imho it's better to link to the top level rtd URL - as publishers can choose which branch/version to redirect to in their "advanced settings" https://docs.readthedocs.io/en/stable/versions.html#redirects-on-root-urls
Suggested change
| .. _Luigi: https://luigi.readthedocs.io/en/latest/ | |
| .. _Luigi: https://luigi.readthedocs.io/ |
There was a problem hiding this comment.
eg https://luigi.readthedocs.io goes to en/stable and https://scoop.readthedocs.io/ goes to io/0.7
graingert
commented
Mar 24, 2022
| @@ -72,14 +72,14 @@ There are a couple of older projects that often get mentioned | |||
| * Pyro_: Remote objects / RPC | |||
|
|
|||
| .. _Luigi: https://luigi.readthedocs.io/en/latest/ | |||
| .. _MPI4Py: http://mpi4py.readthedocs.io/en/stable/ | |||
| .. _MPI4Py: https://mpi4py.readthedocs.io/en/stable/ | |||
| .. _PyZMQ: https://github.com/zeromq/pyzmq | |||
There was a problem hiding this comment.
should this be the rtd URL?
Suggested change
| .. _PyZMQ: https://github.com/zeromq/pyzmq | |
| .. _PyZMQ: https://pyzmq.readthedocs.io/ |
graingert
commented
Mar 24, 2022
| .. _PyZMQ: https://github.com/zeromq/pyzmq | ||
| .. _Celery: http://www.celeryproject.org/ | ||
| .. _Celery: https://docs.celeryq.dev/ | ||
| .. _`IPython Parallel`: https://ipyparallel.readthedocs.io/en/latest/ | ||
| .. _Scoop: https://github.com/soravux/scoop/ |
There was a problem hiding this comment.
should this be the rtd URL?
Suggested change
| .. _Scoop: https://github.com/soravux/scoop/ | |
| .. _Scoop: https://scoop.readthedocs.io/ |
fjetter
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
I agree that it's much nicer to link to the docs and to stay consistent with our links. Thanks @graingert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
celery/celeryproject#52
pre-commit run --all-filesI've only fixed the actual broken/redirecting URLs but I've got some suggestions on cleaning up some cosmetic/consistency issues other URLs